Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📣 Add indexed attribute #163

Merged
merged 3 commits into from
Apr 30, 2023
Merged

📣 Add indexed attribute #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be99cb1
📣 Add indexed attribute
JaredBorders Apr 27, 2023
c66ee6f
📚 Update README
JaredBorders Apr 30, 2023
4ce5f2b
✅ Update tests
JaredBorders Apr 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,12 @@ npm run compile
npm run test
```

4. Run specific test

```
forge test --fork-url $(grep ARCHIVE_NODE_URL_GOERLI_L2 .env | cut -d '=' -f2) --match-test TEST_NAME -vvv
```

> tests will fail if you have not set up your .env (see .env.example)

### Upgradability
Expand Down
6 changes: 3 additions & 3 deletions src/interfaces/IEvents.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ interface IEvents {

event ConditionalOrderPlaced(
address indexed account,
uint256 conditionalOrderId,
uint256 indexed conditionalOrderId,
bytes32 marketKey,
int256 marginDelta,
int256 sizeDelta,
Expand All @@ -93,7 +93,7 @@ interface IEvents {

event ConditionalOrderCancelled(
address indexed account,
uint256 conditionalOrderId,
uint256 indexed conditionalOrderId,
IAccount.ConditionalOrderCancelledReason reason
);

Expand All @@ -109,7 +109,7 @@ interface IEvents {

event ConditionalOrderFilled(
address indexed account,
uint256 conditionalOrderId,
uint256 indexed conditionalOrderId,
uint256 fillPrice,
uint256 keeperFee
);
Expand Down
6 changes: 3 additions & 3 deletions test/utils/ConsolidatedEvents.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ contract ConsolidatedEvents {

event ConditionalOrderPlaced(
address indexed account,
uint256 conditionalOrderId,
uint256 indexed conditionalOrderId,
bytes32 marketKey,
int256 marginDelta,
int256 sizeDelta,
Expand All @@ -62,13 +62,13 @@ contract ConsolidatedEvents {

event ConditionalOrderCancelled(
address indexed account,
uint256 conditionalOrderId,
uint256 indexed conditionalOrderId,
IAccount.ConditionalOrderCancelledReason reason
);

event ConditionalOrderFilled(
address indexed account,
uint256 conditionalOrderId,
uint256 indexed conditionalOrderId,
uint256 fillPrice,
uint256 keeperFee
);
Expand Down