Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various changes #12

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Various changes #12

merged 2 commits into from
Aug 23, 2023

Conversation

sshanks-kx
Copy link
Collaborator

  • removed docs folder (all docs in main README.md) - orig changes made when docs moved from code.kx.com
  • moved example from docs to code (so we know if code breaks with changes)
  • fixed some sonar warnings (e.g. check item null on close)
  • some extra prints on examples to show user whats going on

* removed docs folder (all docs in main README.md)
* moved example from docs to code (so we know if code breaks with changes)
* fixed some sonar warnings (e.g. check item null on close)
* some extra prints on examples to show user whats going on
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 7 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link

@awilson-kx awilson-kx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sshanks-kx sshanks-kx merged commit cf61da8 into KxSystems:main Aug 23, 2023
1 of 2 checks passed
@sshanks-kx sshanks-kx deleted the close branch August 23, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants