Add the search.books API method #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need to add some xml tags
This way, we won't need to rely on more and more verbose names since Goodreads seems to have multiple schemas for a given "type" depending on the endpoint (author, book, etc)
seeing as it's in a responses package now, the prefix is irrelevant.
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the search.books API method.
I took the liberty to fix the remainder of the linting errors in the project with this PR, and also created a package for the response types, since this endpoint introduced an Author and Book type which differed from the types used for other endpoints in the API.
If you have any concerns I'm happy to go over them, and thanks for reviewing!