Skip to content
This repository has been archived by the owner on Nov 12, 2022. It is now read-only.

chore: update dependencies and resolve warnings (Sourcery refactored) #30

Closed
wants to merge 1 commit into from

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Feb 6, 2022

Pull Request #29 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the development branch, then run:

git fetch origin sourcery/development
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from KyleKing February 6, 2022 15:29
@sourcery-ai sourcery-ai bot changed the title build: update dependencies and resolve warnings (Sourcery refactored) chore: update dependencies and resolve warnings (Sourcery refactored) Feb 6, 2022
dash_charts/datatable.py Show resolved Hide resolved
dash_charts/utils_dataset.py Show resolved Hide resolved
tests/examples/ex_marginal_chart.py Show resolved Hide resolved
tests/examples/ex_rolling_chart.py Show resolved Hide resolved
@sourcery-ai
Copy link
Author

sourcery-ai bot commented Feb 6, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.07%.

Quality metrics Before After Change
Complexity 2.73 ⭐ 2.72 ⭐ -0.01 👍
Method Length 44.32 ⭐ 44.19 ⭐ -0.13 👍
Working memory 7.76 🙂 7.79 🙂 0.03 👎
Quality 77.42% 77.35% -0.07% 👎
Other metrics Before After Change
Lines 645 652 7
Changed files Quality Before Quality After Quality Change
dash_charts/datatable.py 71.61% 🙂 71.61% 🙂 0.00%
dash_charts/utils_dataset.py 77.41% ⭐ 77.08% ⭐ -0.33% 👎
tests/examples/ex_marginal_chart.py 90.41% ⭐ 90.66% ⭐ 0.25% 👍
tests/examples/ex_rolling_chart.py 75.15% ⭐ 75.18% ⭐ 0.03% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
dash_charts/utils_dataset.py store_reference_tables 9 🙂 119.99 😞 16 ⛔ 48.60% 😞 Try splitting into smaller methods. Extract out complex expressions
dash_charts/datatable.py split_filter_part 17 🙂 99.99 🙂 11 😞 51.44% 🙂 Extract out complex expressions
tests/examples/ex_rolling_chart.py RollingDemo.create_elements 1 ⭐ 109.99 🙂 13 😞 61.46% 🙂 Extract out complex expressions
tests/examples/ex_rolling_chart.py RollingDemo.return_layout 0 ⭐ 86 🙂 15 😞 63.10% 🙂 Extract out complex expressions
dash_charts/utils_dataset.py add_meta_table_records_sql 0 ⭐ 88.98 🙂 10 😞 70.55% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@KyleKing KyleKing closed this Feb 6, 2022
@KyleKing KyleKing deleted the sourcery/development branch February 6, 2022 16:23
Copy link
Owner

@KyleKing KyleKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant