Consistant decleration of a silce of Ambassador Hosts

Correcting the inconsistancy in the way an empty slice of Ambassador Hosts were declared so it is clean and clearer. Thanks to alebedev87 for catching this in kubernetes-sigs#2633 (comment)
KyleMartin901 · Jun 7, 2022 · 2482ef5 · 2482ef5
1 parent 51e3633
commit 2482ef5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/source/ambassador_host.go b/source/ambassador_host.go
@@ -119,7 +119,7 @@ func (sc *ambassadorHostSource) Endpoints(ctx context.Context) ([]*endpoint.Endp
 	}
 
 	// Get a list of Ambassador Host resources
-	var ambassadorHosts []*ambassador.Host
+	ambassadorHosts := []*ambassador.Host{}
 	for _, hostObj := range hosts {
 		unstructuredHost, ok := hostObj.(*unstructured.Unstructured)
 		if !ok {

diff --git a/source/ambassador_host_test.go b/source/ambassador_host_test.go
@@ -569,7 +569,7 @@ func testAmbassadorSourceEndpoints(t *testing.T) {
 		ti := ti
 		t.Run(ti.title, func(t *testing.T) {
 			// Create a slice of Ambassador Hosts
-			ambassadorHosts := make([]*ambassador.Host, 0)
+			ambassadorHosts := []*ambassador.Host{}
 
 			// Convert our test data into Ambassador Hosts
 			for _, host := range ti.ambassadorHostItems {