Revert the recent changes as they are breaking the install.

[Kyon147]

No description provided.

[rvibit]

@Kyon147 what are the things it is breaking? I installed version 17.3.3 yesterday and one issue i noticed about the shop param is not being passed to the billable modal. are there any other things that are broken?

[Kyon147]

I've tested the billing and it works as expected.

Are you making sure you are passing the shop, like so?

<p><a href="{{ route('billing', ['plan' => 2, 'shop' => Auth::user()->name]) }}">Upgrade</a></p>

[rvibit]

I've tested the billing and it works as expected.

Are you making sure you are passing the shop, like so?

<p><a href="{{ route('billing', ['plan' => 2, 'shop' => Auth::user()->name]) }}">Upgrade</a></p>

Yes, I have already fixed that issue by passing the shop param manually. I just wanted to know what other issues you are facing so you reverted the changes?

[Kyon147]

There were two recent PR's by another person which added the host down into the billing etc but it seemed it could be causing some issues on new installs.

To keep things clean, I reverted back to before those PRs were added in, and res-tested and the package is working as expected.

[rvibit]

There were two recent PR's by another person which added the host down into the billing etc but it seemed it could be causing some issues on new installs.

To keep things clean, I reverted back to before those PRs were added in, and res-tested and the package is working as expected.

ok got it, thanks for the update.

[jackwefullfill]

hi @Kyon147, this means that #1 and #2 are not valid right? and we are still not able to load the app inside admin.shopify.com?

[Kyon147]

We need to remove the shopOrigin from the appBridge set up as the main concern. Then it just needs to be tested on an admin.shopify domain.