Ignore whitespace-only lines #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
force-pushed
the
gh-1-line-with-whitespace-only
branch
from
1d21230
to
276fc17
Compare
…acters, fix test in cuttlefish_conf
lukebakken
force-pushed
the
gh-1-line-with-whitespace-only
branch
from
276fc17
to
143dcad
Compare
lukebakken
commented
Aug 3, 2019
michaelklishin
approved these changes
Aug 3, 2019
michaelklishin
added a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Aug 3, 2019
All tests pass locally, let's see how package tests do. References Kyorai/cuttlefish#2.
michaelklishin
added a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Aug 3, 2019
This reverts commit ebfb4ea. `config_schema` tests that combine a new style and advanced config snippets fail. This needs further investigation. References Kyorai/cuttlefish#2.
|
Thank you very much for fixing the bug so quickly! |
Merged
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
Thanks to @puresilk for the easy-to-follow reproduction steps.