Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to prevent templates impacting remaining content #523

Closed
kezz opened this issue Oct 23, 2021 · 1 comment · Fixed by #707
Closed

Add a way to prevent templates impacting remaining content #523

kezz opened this issue Oct 23, 2021 · 1 comment · Fixed by #707

Comments

@kezz
Copy link
Member

kezz commented Oct 23, 2021

Something like <my_template/> which would resolve the template whilst preventing any tags inserted from bleeding into remaining strings.

Essentially shorthand for <span><my_template></span>, considering KyoriPowered/adventure-text-minimessage#178.

@kashike kashike transferred this issue from KyoriPowered/adventure-text-minimessage Nov 28, 2021
@zml2008 zml2008 added this to the 4.10.0 milestone Feb 7, 2022
@zml2008
Copy link
Member

zml2008 commented Feb 7, 2022

This should be easy with #672 -- it just depends on the value of Tag#allowsChildren(). We could incorporate the same logic into the parser in order to support / for self-closing tags.

@zml2008 zml2008 modified the milestones: 4.10.0, 4.11.0 Feb 24, 2022
zml2008 added a commit that referenced this issue Feb 26, 2022
This simplifies the language for cases where certain tags have zero
children.

Fixes GH-704
Fixes GH-523
@rymiel rymiel linked a pull request Feb 26, 2022 that will close this issue
zml2008 added a commit that referenced this issue Feb 27, 2022
This simplifies the language for cases where certain tags have zero
children.

Fixes GH-704
Fixes GH-523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants