Revise text component replacement #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashike
requested changes
Aug 28, 2020
api/src/main/java/net/kyori/adventure/text/TextComponentImpl.java
Outdated
Show resolved
Hide resolved
api/src/main/java/net/kyori/adventure/text/event/HoverEvent.java
Outdated
Show resolved
Hide resolved
api/src/main/java/net/kyori/adventure/text/renderer/ComponentRenderer.java
Outdated
Show resolved
Hide resolved
zml2008
force-pushed
the
feature/text-replacement
branch
from
e6f4920
to
7653aae
Compare
kashike
requested changes
Aug 29, 2020
api/src/main/java/net/kyori/adventure/text/AbstractComponent.java
Outdated
Show resolved
Hide resolved
api/src/main/java/net/kyori/adventure/text/event/HoverEvent.java
Outdated
Show resolved
Hide resolved
zml2008
force-pushed
the
feature/text-replacement
branch
from
9539829
to
2ee28d0
Compare
zml2008
added a commit
that referenced
this pull request
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now properly handles non-
TextComponentchildren, plus traversesTranslatableComponents and hover events.At some point the logic in this and in
TranslatableComponentRenderershould be abstracted out into a common component visitor. There's also potential to expand the exposed replacement api -- this PR doesn't expose any new functionality.