api: Add Audience.toAudience() #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashike
requested changes
Sep 14, 2020
api/src/test/java/net/kyori/adventure/audience/AudienceTest.java
Outdated
Show resolved
Hide resolved
| * | ||
| * @return a collector to create a forwarding audience | ||
| */ | ||
| static @NonNull Collector<? super Audience, Collection<Audience>, ForwardingAudience> toAudience() { |
There was a problem hiding this comment.
Suggested change
| static @NonNull Collector<? super Audience, Collection<Audience>, ForwardingAudience> toAudience() { | |
| static @NonNull Collector<? super Audience, Collection<Audience>, ForwardingAudience> collector() { |
There was a problem hiding this comment.
I'm -1 on this, it makes static imports too hard to read: stream.collect(collector()) is probably quite confusing. stream.collect(toAudience()) is unambiguous.
kashike
approved these changes
Sep 15, 2020
astei
changed the title
kashike
force-pushed
the
feature/audience-collector
branch
from
e8a1ece
to
a4787e1
Compare
astei
force-pushed
the
feature/audience-collector
branch
from
a4787e1
to
b69acc1
Compare
kashike
approved these changes
Oct 10, 2020
zml2008
pushed a commit
that referenced
this pull request
Dec 7, 2021
Resolves #156. I swear I did this before but i guess it got lost in the rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This arose out of somewhat related discussion that led to #155 being filed, but it's not related.
This API adds a collector for
Audiences. It is a convenient and idiomatic shorthand forAudience.of(stream.collect(Collectors.toList()))and is more concise:stream.collect(Audience.toAudience())