API addition for translations #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's not possible to know serverside whether or not a translation exists - the translatable component supports any key defined in a client resource pack as well. |
|
I was thinking about plugin registered keys that are unlikely to exist on client resource packs. Perhaps, should mention this limitation in the documentation, or change the method name to better reflect that? |
kashike
reviewed
Feb 26, 2021
api/src/main/java/net/kyori/adventure/translation/TranslationRegistry.java
Outdated
Show resolved
Hide resolved
zml2008
approved these changes
Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a method to check if a translation key has any registered translations.
This allows one to easily handle a missing translation key using a custom fallback.