Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jackson module #42

Closed
wants to merge 20 commits into from
Closed

Jackson module #42

wants to merge 20 commits into from

Conversation

XakepSDK
Copy link

@XakepSDK XakepSDK commented Aug 6, 2019

Add support for jackson

@XakepSDK
Copy link
Author

XakepSDK commented Aug 6, 2019

Tests were taken from GSON version.
Known itches: uses static access to mapper to convert object to node, will be fixed after this resolved: FasterXML/jackson-databind#2411
It's not a problem, but it would be better if i could avoid this access.

Known issues:
I'm doing this:

private static final Version VERSION = VersionUtil.parseVersion("3.0.2", "net.kyori", "text-serializer-jackson");

How can i use values from gradle?

@XakepSDK
Copy link
Author

XakepSDK commented Sep 3, 2019

Bump

@liach
Copy link
Contributor

liach commented Sep 3, 2019

Consider formatting your code with code style/inspections from https://github.com/kashike/dotfiles.intellij

@XakepSDK
Copy link
Author

Fixed

@XakepSDK
Copy link
Author

Do i need make more changes?

@kashike
Copy link
Member

kashike commented Sep 29, 2019

Could you please rebase against master?

@XakepSDK
Copy link
Author

I think i did it. Should i squash this mess?

@XakepSDK
Copy link
Author

Well, this git history looks so sick. Let me re-do PR.

@XakepSDK XakepSDK closed this Sep 29, 2019
@XakepSDK XakepSDK mentioned this pull request Sep 29, 2019
@mikroskeem
Copy link
Contributor

Could've just used the force, Luke ;) git push --force

zml2008 pushed a commit that referenced this pull request Dec 7, 2021
Signed-off-by: MiniDigger <admin@minidigger.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants