Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(key): try to include additional information in error messages when an invalid character has been detected in a Key #887

Merged
merged 1 commit into from
Apr 30, 2023
Merged

feat(key): try to include additional information in error messages when an invalid character has been detected in a Key #887

merged 1 commit into from
Apr 30, 2023
+52 −6

Conversation

kashike
Copy link
Member

@kashike kashike commented Mar 26, 2023 •
edited
Loading

Before:

InvalidKeyException: Non [a-z0-9/._-] character in value of Key[carbon:global   ]

After:

InvalidKeyException: Non [a-z0-9_.-] character in value of Key[carbon:global   ] at index 6 (' ', bytes: [0])

@kashike kashike added this to the 4.14.0 milestone Mar 26, 2023
kezz
kezz requested changes Mar 26, 2023
View reviewed changes
key/src/main/java/net/kyori/adventure/key/Key.java Outdated Show resolved Hide resolved
key/src/main/java/net/kyori/adventure/key/Key.java Outdated Show resolved Hide resolved
@kashike kashike requested a review from kezz April 28, 2023 04:50
@kashike @jpenilla
feat(key): try to include additional information in error messages wh…
bcc3d2d 
…en an invalid character has been detected in a Key

Co-authored-by: Jason <11360596+jpenilla@users.noreply.github.com>
@zml2008 zml2008 self-assigned this Apr 30, 2023
@zml2008 zml2008 added this pull request to the merge queue Apr 30, 2023
Merged via the queue into main/4 with commit 0850ada Apr 30, 2023
@zml2008 zml2008 deleted the feature/key-errors branch April 30, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zml2008 zml2008 zml2008 approved these changes

@kezz kezz kezz approved these changes

@jpenilla jpenilla jpenilla approved these changes

Assignees

@zml2008 zml2008

Labels
area: key type: enhancement
Projects
None yet
Milestone
4.14.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kashike @zml2008 @kezz @jpenilla