Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComponentEncoder #899

Merged
merged 1 commit into from Apr 11, 2023
Merged

ComponentEncoder #899

merged 1 commit into from Apr 11, 2023

Conversation

rymiel
Copy link
Member

@rymiel rymiel commented Apr 11, 2023

ComponentEncoder is akin to ComponentSerializer, except it doesn't provide deserialization. This is intended to be used in #898.

ComponentSerializer now extends ComponentEncoder, but still overrides the methods with exact copies, to keep the javadocs more clear. These originals also retain their old @since tags.

Copy link
Member

@kezz kezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick

ComponentEncoder is akin to ComponentSerializer, except it doesn't
provide deserialization. This is intended to be used in #898.

ComponentSerializer now extends ComponentEncoder, but still overrides
the methods with exact copies, to keep the javadocs more clear.
These originals also retain their old `@since` tags.
@kashike kashike added this to the 4.14.0 milestone Apr 11, 2023
@rymiel rymiel added this pull request to the merge queue Apr 11, 2023
Merged via the queue into main/4 with commit 64f8f9f Apr 11, 2023
3 checks passed
@rymiel rymiel deleted the feat/text-encoder branch April 11, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants