Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename static constructors #923

Merged
merged 8 commits into from May 12, 2023

Conversation

powercasgamer
Copy link
Contributor

@powercasgamer powercasgamer commented May 11, 2023

Closes #454

@powercasgamer powercasgamer marked this pull request as ready for review May 11, 2023 20:08
@powercasgamer powercasgamer changed the title chore: rename static in HoverEvent.ShowItem chore: rename static constructors May 11, 2023
Copy link
Member

@zml2008 zml2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

> Task :adventure-text-serializer-gson:compileTestJava
/home/runner/work/adventure/adventure/text-serializer-gson/src/test/java/net/kyori/adventure/text/serializer/gson/TranslatableComponentTest.java:69: warning: [deprecation] of(Key,UUID,Component) in ShowEntity has been deprecated
          .hoverEvent(HoverEvent.showEntity(HoverEvent.ShowEntity.of(
                          

one last deprecation from Actions

@powercasgamer
Copy link
Contributor Author

> Task :adventure-text-serializer-gson:compileTestJava
/home/runner/work/adventure/adventure/text-serializer-gson/src/test/java/net/kyori/adventure/text/serializer/gson/TranslatableComponentTest.java:69: warning: [deprecation] of(Key,UUID,Component) in ShowEntity has been deprecated
          .hoverEvent(HoverEvent.showEntity(HoverEvent.ShowEntity.of(
                          

one last deprecation from Actions

fixed

@zml2008 zml2008 enabled auto-merge May 12, 2023 14:46
@zml2008 zml2008 added this pull request to the merge queue May 12, 2023
Merged via the queue into KyoriPowered:main/4 with commit 7073ec3 May 12, 2023
2 checks passed
@powercasgamer powercasgamer deleted the chore/rename-static branch May 12, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename remaining of static constructor methods.
3 participants