Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Cancellable FlattenerListener #996

Merged
merged 2 commits into from
Dec 7, 2023
Merged

feature: Cancellable FlattenerListener #996

merged 2 commits into from
Dec 7, 2023

Conversation

FxMorin
Copy link
Contributor

@FxMorin FxMorin commented Nov 23, 2023

Adds the ability to stop a flattener while its running.
This allows developers to make implementations with early exit conditions.

@zml2008 zml2008 added this to the 4.15.0 milestone Nov 23, 2023
zml2008
zml2008 approved these changes Dec 2, 2023
View reviewed changes
Copy link
Member

@zml2008 zml2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for this! Just needs style fixes and it should be ready to go.

@zml2008 zml2008 self-assigned this Dec 7, 2023
@zml2008 zml2008 added this pull request to the merge queue Dec 7, 2023
Merged via the queue into KyoriPowered:main/4 with commit ec7b524 Dec 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zml2008 zml2008 zml2008 approved these changes

Assignees

@zml2008 zml2008

Labels
area: api type: enhancement
Projects
None yet
Milestone
4.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FxMorin @zml2008