Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nested message sections #12

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Tim203
Copy link
Member

@Tim203 Tim203 commented Jul 13, 2023

This PR adds support for nested message sections like:

public interface RootSection {
    HelloSection hello();

    @MessageSection("hello")
    interface HelloSection {
        @Message("world")
        String world(@Receiver User user);
    }
}

and

@MessageSection("hello")
public interface HelloSection {
    @Message("world")
    WorldSection world();

    @MessageSection(delimiter='-')
    interface WorldSection {
        @Message("moonshine")
        String moonshine(@Receiver User user);
    }
}

(first one results in key 'hello.world', second one 'hello.world-moonshine')

Please let me know if there are some changes you'd like to see.

@Tim203 Tim203 marked this pull request as ready for review July 13, 2023 09:46
Copy link
Member

@broccolai broccolai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, I'll touch up a few things and merge it. Thank you!

Sorry it took so long feels like only yesterday I saw your ping haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants