handle error of evaluation if items.is_empty()

L-M-Sherlock · Apr 14, 2024 · 7f0a557 · 7f0a557
1 parent e269983
commit 7f0a557
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/rslib/src/scheduler/fsrs/weights.rs b/rslib/src/scheduler/fsrs/weights.rs
@@ -162,6 +162,9 @@ impl Collection {
             .get_revlog_entries_for_searched_cards_in_card_order()?;
         let (items, review_count) =
             fsrs_items_for_training(revlogs, timing.next_day_at, ignore_revlogs_before);
+        if items.is_empty() {
+            return Err(AnkiError::FsrsInsufficientData);
+        }
         anki_progress.state.reviews = review_count as u32;
         let fsrs = FSRS::new(Some(weights))?;
         Ok(fsrs.evaluate(items, |ip| {

diff --git a/ts/routes/deck-options/FsrsOptions.svelte b/ts/routes/deck-options/FsrsOptions.svelte
@@ -185,6 +185,8 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
                     }
                 },
             );
+        } catch (err) {
+            alert(tr.deckConfigNotEnoughHistory());
         } finally {
             checkingWeights = false;
         }