Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #45

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Update dependencies #45

merged 2 commits into from
Apr 2, 2024

Conversation

L0um15
Copy link
Owner

@L0um15 L0um15 commented Mar 13, 2024

Update critical dependencies

@narutoshocker
Copy link

narutoshocker commented Mar 27, 2024

log-20240327153313.txt
tested these changes on my local branch and was able to download files (originally this would crash on any file attempt)
Note: noticed that the following error output exists (happens at the end of the download, so the file still exists and works fine):

Unhandled exception. System.Net.Http.HttpRequestException: Response status code does not indicate success: 404 (Not Found).
   at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()
   at System.Net.Http.HttpClient.GetStringAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken)
   at Spotisharp.Client.Services.MusixmatchService.SearchLyricsFromText(String query) in E:\Coding\Repos\Spotisharp.Client\Services\MusixmatchService.cs:line 14
   at Program.<>c__DisplayClass0_0.<<<Main>$>b__0>d.MoveNext() in E:\Coding\Repos\Spotisharp.Client\Program.cs:line 280
--- End of stack trace from previous location ---
   at Program.<Main>$(String[] args) in E:\Coding\Repos\Spotisharp.Client\Program.cs:line 132
   at Program.<Main>(String[] args)

@L0um15
Copy link
Owner Author

L0um15 commented Apr 2, 2024

Tested. No issues found, merging.
#44

@L0um15 L0um15 merged commit 0e73666 into dev Apr 2, 2024
@L0um15 L0um15 deleted the update_dependencies branch May 17, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants