Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

artisan route:cache fails #20

Closed
mtutumlu opened this issue Nov 16, 2016 · 5 comments
Closed

artisan route:cache fails #20

mtutumlu opened this issue Nov 16, 2016 · 5 comments

Comments

@mtutumlu
Copy link

artisan route:cache command fails due to more than one inclusion of the helper.php files.

I have fixed the issue with updating "include $helper;" to "include_once $helper;" in boot() method of ModuleServiceProvider class.

@Artem-Schander
Copy link
Collaborator

thanks. i'll take a look later

@galexth
Copy link

galexth commented Nov 18, 2016

with this update all my tests fail(

@Artem-Schander
Copy link
Collaborator

would you please provide some examples?

@galexth
Copy link

galexth commented Nov 18, 2016

I'm working on in right now, i've just ran unit tests and module part of the has failed right after the package update
Maybe laravel creates multiple app instances while testing

$this->json('PUT', "module-route")->seeJsonStructure(...);
 Argument #2 (No Value) of PHPUnit_Framework_Assert::assertArrayHasKey() must be a array or ArrayAccess

@mtutumlu
Copy link
Author

include_once $helper; is worked but include_once $routes; fails the following code not return the module routes:

      $app = require $this->laravel->bootstrapPath().'/app.php';
      $app->make('Illuminate\Contracts\Console\Kernel')->bootstrap();
      return $app['router']->getRoutes();

Artem-Schander added a commit that referenced this issue Nov 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants