Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Logo Images to Roses Score & Added Match Overview #55

Merged
merged 3 commits into from
Apr 25, 2017

Conversation

danleedham
Copy link
Collaborator

Allows Match name (Top Bar) and Start time / Half time etc. (Bottom
Bar) to be input and controlled separately.
@danleedham danleedham changed the title Added Logo Images to Roses Score Added Logo Images to Roses Score & Added Match Overview Apr 21, 2017
@danleedham
Copy link
Collaborator Author

New Football Thing.zip

I've also adapted the Roses score with logos to be used as a this match is 'coming up' graphic or as a 'half time/fulltime score' graphic. Video shows what's going on and the issue with using more than two lines of text as the header.

Copy link
Member

@stephenrob stephenrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine besides the multi line of text being hidden behind the logo - around 1/2 way through the video you will see what I mean. Probably can fix it with margin or padding.

@danleedham
Copy link
Collaborator Author

I went with a more scientific approach to padding. Before I'd only had 40px for each, but in fact each logo covers the h1 text slightly differently even through the center of each is in the same relative place on each side.

screen shot 2017-04-23 at 15 52 50

@tjenkinson
Copy link
Member

tjenkinson commented Apr 23, 2017 via email

@stephenrob stephenrob merged commit d60162d into master Apr 25, 2017
@stephenrob stephenrob deleted the Indv-Hide-3rds branch April 25, 2017 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants