Ui live indicator #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The admin ui now has toggleable live symbles within the $scope.menu array, however i cant find a way of getting that information from the cg controllers
moschopsuk
approved these changes
Apr 11, 2018
stephenrob
requested changes
Apr 11, 2018
package.json
Outdated
| @@ -1,13 +1,15 @@ | |||
| { | |||
| "name": "la1tv-roses-graphics", | |||
| "version": "1.0.0", | |||
| "version": "2018.0.1", | |||
There was a problem hiding this comment.
When was the version change from SemVer ?
There was a problem hiding this comment.
we werent semvering tbf, plus i feel it makes more sense to version on the year and minor/patching
There was a problem hiding this comment.
Lets not change the versioning scheme in this PR regarding UI live indicators we can switch to this at a later date
There was a problem hiding this comment.
fair play, think its worth changing though
public/js/dashboard.js
Outdated
| @@ -263,6 +289,22 @@ app.controller('lowerThirdsCGController', ['$scope', 'localStorageService', 'soc | |||
|
|
|||
| var stored = localStorageService.get('lower_thirds'); | |||
|
|
|||
| const showLiveLT = $scope => { | |||
There was a problem hiding this comment.
Expanding showLiveLT to showLiveLowerThird etc helps with readability of code.
There was a problem hiding this comment.
argeed will fix in a mo
|
added netball aswell now its been pulled in |
|
changed back to semver now |
stephenrob
approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.