1. ENH: Remove Pyo for Pyglet, add Py3k support #112
Conversation
|
I think it is charitable to pyo that you call this ENH rather than FIX On Wed, Mar 26, 2014 at 3:19 PM, Eric89GXL notifications@github.com wrote:
|
larsoner
changed the title
larsoner
changed the title
larsoner
changed the title
|
Tests now pass on Travis (although it's hitting some silly timeout unrelated to us ATM), and we have Py3k support (hooray!). I've actually now tested the code on my OSX machine, and it works there, too. This is ready for review. Out of the open PRs, this should be reviewed and merged first -- I've updated the titles on my other open PRs to make it clearer the order they should be dealt with. (The other PRs will require some rebasing after this is merged.) |
| self.noise_array = np.array(np.c_[noise, -1.0 * noise], order='C') | ||
| self.noise = Sound(self.noise_array, loop=True) | ||
| self.noise_array = np.array((noise, -1.0 * noise)) | ||
| self.noise = SoundPlayer(self.noise_array, self.fs, loop=True) |
There was a problem hiding this comment.
So, when we create a SoundController object, the noise will start playing automatically? That seems like undesirable behavior for, e.g., training phases.
There was a problem hiding this comment.
no, self.noise.play() must be called
There was a problem hiding this comment.
In that case why do we set self._noise_playing = True as part of __init__ (in line 100 below)?
There was a problem hiding this comment.
See below where _noise_playing is actually used. Need some way of storing the state so that, if a user sets the noise level, we know whether to play the new noise or not.
1. ENH: Remove Pyo for Pyglet, add Py3k support. Ready to rebase the other PRs, @Eric89GXL?
Ready for review and merge.