MRG: CircleCI 2.0

[larsoner]

Closes #349.

[larsoner]

@drammock ready for review/merge from my end

[drammock]

I can review this on monday when I'm back in the office

[drammock]

(three) [~/B/expyfun] $ git chb testcircle eric/circle 
Branch testcircle set up to track remote branch circle from eric.
Switched to a new branch 'testcircle'
(three) [~/B/expyfun] $ make test
rm -rf build
find . -name "*.pyc" | xargs rm -f
find . -name "*.so" | xargs rm -f
find . -name "*.pyd" | xargs rm -f
rm -f tags
find . -name "__pycache__" | xargs rm -rf
rm -f .coverage
pytest expyfun
usage: pytest [options] [file_or_dir] [file_or_dir] [...]
pytest: error: unrecognized arguments: --cov=expyfun --cov-report=
  inifile: /home/drmccloy/Builds/expyfun/setup.cfg
  rootdir: /home/drmccloy/Builds/expyfun
Makefile:44: recipe for target 'nosetests' failed
make: *** [nosetests] Error 2

[larsoner]

install pytest-cov

[drammock]

is my version of pytest too old? (maybe we should check for that?)

[larsoner]

No you need both pytest and pytest-cov packages

[drammock]

test pass in my python3 env, but in my (rarely-used) py2 environment I'm getting an enormous traceback culminating in RuntimeError: maximum recursion depth exceeded. Should I ignore it or try to track it down?

[drammock]

found problem. Old pip-installed version of py was overriding newer conda-installed version of py. sigh

[larsoner]

https://xkcd.com/1987/

[drammock]

today is not my day:

(three) [~] $ conda install argcomplete
Solving environment: - Segmentation fault (core dumped)

[larsoner]

Oh wow, never seen that one before.

[drammock]

other than one comment LGTM

[drammock]

this line I don't get. why is got_fname here?

[drammock]

(i.e., why would the got_version ever equal the file path, and why would we want to allow that?)

[larsoner]

In assert statements what follows the comma is a message (it is not creating a tuple), e.g.:

>>> assert 'dan' in 'cool', 'he is not'
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AssertionError: he is not

In this case it's useful to have the filename printed, especially when using pytest --pdb.

[drammock]

I've been pwned

[drammock]

thanks @larsoner