Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reshape array for CascadeForestRegressor in customized mode #67

Merged
merged 3 commits into from
Apr 13, 2021

Conversation

xuyxu
Copy link
Member

@xuyxu xuyxu commented Apr 12, 2021

  • fix the problem
  • improve the coverage of unit tests

@xuyxu
Copy link
Member Author

xuyxu commented Apr 12, 2021

cc @kangwenhao.

Thanks for reporting! This is a problem due to the inconsistency on the array shape of predictors. For example, for univariate regression, the prediction of some predictors (e.g., XGBRegressor) is an array of shape (n_samples,), wheras that of other predictors could be an array of shape (n_samples, 1).

In this PR, we have added additional operations to unify the array shape under different cases.

@kangwenhao
Copy link

Thank you for your help. Good luck!

@xuyxu
Copy link
Member Author

xuyxu commented Apr 12, 2021

Please follow the steps below, and let me know if you have any problem:

  • Uninstall the current version: pip uninstall deep-forest
  • Download the wheels built in this PR: ZIP
  • Select the appropriate wheel according to your platform and Python version
  • Open a terminal and switch it into the folder that contains the wheel
  • run pip install XXXX.whl

Copy link
Member Author

@xuyxu xuyxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xuyxu xuyxu merged commit a4be167 into master Apr 13, 2021
@xuyxu xuyxu deleted the array_layout_fix branch April 13, 2021 05:57
@xuyxu xuyxu restored the array_layout_fix branch April 15, 2021 08:35
@xuyxu xuyxu deleted the array_layout_fix branch April 15, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants