Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix raise error problem #88

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Fix raise error problem #88

merged 2 commits into from
Jul 15, 2021

Conversation

IncubatorShokuhou
Copy link
Contributor

Fix #87
By changing the error type raised in __getitem__ from ValueError to IndexError, now the CascadeForestRegressor() and CascadeForestClassifier() object is a normal, iteratable iterator.

xuyxu
xuyxu reviewed Jul 15, 2021
View reviewed changes
Copy link
Member

@xuyxu xuyxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xuyxu
Copy link
Member

xuyxu commented Jul 15, 2021

Merged, thanks!

@xuyxu xuyxu merged commit 51a8e70 into LAMDA-NJU:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuyxu xuyxu xuyxu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] CascadeForestRegressor somehow cannot be inserted into a DataFrame
2 participants
@IncubatorShokuhou @xuyxu