Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust code to Blue Style #205

Merged
merged 5 commits into from
Oct 8, 2020
Merged

Adjust code to Blue Style #205

merged 5 commits into from
Oct 8, 2020

Conversation

raphaelsaavedra
Copy link
Member

@raphaelsaavedra raphaelsaavedra commented Oct 6, 2020

This is a big one.

Main changes are removing blank spaces, indentation of line breaks, spacing in kwargs and type parameters, and mutating functions returning the objects they mutate.

Copy link
Member

@guilhermebodin guilhermebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix the doctests

@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #205 into master will decrease coverage by 0.53%.
The diff coverage is 86.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
- Coverage   89.32%   88.79%   -0.54%     
==========================================
  Files          21       21              
  Lines        1387     1401      +14     
==========================================
+ Hits         1239     1244       +5     
- Misses        148      157       +9     
Impacted Files Coverage Δ
src/optimizers.jl 100.00% <ø> (ø)
src/prints.jl 4.76% <0.00%> (-3.14%) ⬇️
src/filters/multivariate_kalman_filter.jl 66.40% <70.73%> (ø)
src/forecast.jl 89.58% <71.42%> (+0.94%) ⬆️
src/filters/univariate_kalman_filter.jl 73.33% <72.50%> (ø)
src/kalman_filter_and_smoother.jl 89.06% <75.00%> (ø)
src/hyperparameters.jl 90.32% <82.97%> (-4.06%) ⬇️
src/smoothers/kalman_smoother.jl 94.28% <91.30%> (ø)
src/models/arima.jl 96.10% <97.61%> (ø)
src/filters/regression_kalman_filter.jl 100.00% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07d4fed...489280d. Read the comment docs.

@raphaelsaavedra raphaelsaavedra merged commit 67341f1 into master Oct 8, 2020
@guilhermebodin guilhermebodin deleted the refactoring-to-0.4 branch April 2, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants