Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better condition check for Raspberry Pi #1

Merged
merged 1 commit into from Feb 5, 2021

Conversation

mikan
Copy link
Contributor

@mikan mikan commented Feb 3, 2021

The current Makefile condition check is based on the hostname, but it is too environmentally dependent. As a better practice, I suggest a checking method that uses lsb_release -i instead of uname -n.

lsb_release provides distribution specific information of your running operating system, for example:

$ lsb_release -a
No LSB modules are available.
Distributor ID: Raspbian
Description:    Raspbian GNU/Linux 10 (buster)
Release:        10
Codename:       buster

Unfortunately, I don't have any other system like Armadillo, so those checks still use uname -n in this PR.

@NaotakaSaito NaotakaSaito merged commit c293193 into LAPIS-Lazurite:master Feb 5, 2021
@NaotakaSaito
Copy link
Member

Thank you for your comment. I commited your pull request.

@mikan mikan deleted the patch-1 branch February 5, 2021 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants