Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keygen spam check #297

Merged
merged 13 commits into from
Jan 13, 2023
Merged

Keygen spam check #297

merged 13 commits into from
Jan 13, 2023

Conversation

tbssajal
Copy link
Collaborator

@tbssajal tbssajal commented Oct 20, 2022 •
edited
Loading

not tested yet

tested

sgladkov
sgladkov previously approved these changes Nov 4, 2022
View reviewed changes
@tbssajal
Copy link
Collaborator Author

tbssajal commented Dec 5, 2022 •
edited
Loading

Hardfork height must be set before keygen starts and after a cycle is finished, ie hardfork_height % cycle_duration > 0 and hardfork_height % cycle_duration < cycle_duration / 2
Release has to be made following the same condition. When released: current_height % cycle_duration > 0 and current_height % cycle_duration < cycle_duration / 2 must be true

soloway2010
soloway2010 previously approved these changes Jan 10, 2023
View reviewed changes
@tbssajal
Copy link
Collaborator Author

needs hardfork

@tbssajal tbssajal dismissed stale reviews from soloway2010 and sgladkov via c728bad January 13, 2023 09:10
@tbssajal tbssajal merged commit e7bb48b into dev Jan 13, 2023
@tbssajal tbssajal deleted the keygen-spam-check branch January 13, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soloway2010 soloway2010 soloway2010 left review comments

@sgladkov sgladkov sgladkov left review comments

@Anachor Anachor Awaiting requested review from Anachor

@dkhrustalev dkhrustalev Awaiting requested review from dkhrustalev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tbssajal @soloway2010 @sgladkov