Refactoring of LArSoft geometry system #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Makes use of range-v3 instead of util::span - Introduces sentinel types - Introduces iteration policies - Separates GeoObjectSorter objects from ChannelMapAlg implementations
Includes: - Moving planes and wires to readout geometry. - Removing geometry re-loading. - Restructuring GeoObjectSorters to provide comparison operations. - Adding WireReadoutSorters. - Adopting left-const placement.
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
This was referenced Oct 25, 2023
This was referenced Nov 1, 2023
|
Pull request #37 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again. |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
Merged with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Substantial refactoring of LArSoft geometry system to support pixel geometries.
Includes:
ROOTconfiguration parameter, which was never usedRequires LArSoft/larcoreobj#19