Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultipleChoiceSelection.h: added missing inline directives #42

Merged
merged 2 commits into from Aug 14, 2023

Conversation

PetrilloAtWork
Copy link
Contributor

In the sea of templates, I had missed the few functions which were not templated and need to be declared inline.

It should fix linking problems in icaruscode.

@FNALbuild
Copy link
Contributor

A new Pull Request was created by @PetrilloAtWork (Gianluca Petrillo) for develop.

It involves the following packages:

lardataalg

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

@FNALbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@FNALbuild
Copy link
Contributor

-code-checks
Pull request failed code-formatting checks. Please ensure that cetmodules has been setup and execute the following command from the top-level directory of your repository:

format-code \
  lardataalg/Utilities/MultipleChoiceSelection.h

Then commit the changes and push them to your PR branch.

@FNALbuild
Copy link
Contributor

Pull request #42 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.

@FNALbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@FNALbuild
Copy link
Contributor

+code-checks

@knoepfel knoepfel added this to Awaiting triage in LArSoft pull requests Aug 14, 2023
@knoepfel knoepfel moved this from Awaiting triage to Approval in progress in LArSoft pull requests Aug 14, 2023
@knoepfel
Copy link
Member

trigger build

@FNALbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@FNALbuild
Copy link
Contributor

+LArSoft tests OK on slf7 for c7:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20284&builds=
+build

@FNALbuild
Copy link
Contributor

+LArSoft tests OK on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20283&builds=
+build

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

-icarus tests warning, with build warning,, with ignored warning for build, on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:icarus/view_builds/index?offset=0&builds=icarus_ci/7918&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20283&builds=

@FNALbuild
Copy link
Contributor

-sbnd tests warning, with build warning,, with ignored warning for build, on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:sbnd/view_builds/index?offset=0&builds=sbnd_ci/12479&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20283&builds=

@FNALbuild
Copy link
Contributor

-dune tests tests warning, with build warning,, with ignored warning for build, on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:dune/view_builds/index?offset=0&builds=dune_ci/15880&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20283&builds=

@FNALbuild
Copy link
Contributor

@tomjunk
Copy link
Contributor

tomjunk commented Aug 14, 2023

Approved

@FNALbuild
Copy link
Contributor

This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged.)

@lgarren
Copy link
Member

lgarren commented Aug 14, 2023

approve

@lgarren lgarren merged commit 7e26964 into LArSoft:develop Aug 14, 2023
1 check passed
LArSoft pull requests automation moved this from Approval in progress to Merged into develop Aug 14, 2023
@lgarren lgarren moved this from Merged into develop to Included in release in LArSoft pull requests Aug 21, 2023
@PetrilloAtWork PetrilloAtWork deleted the feature/gp_MultiOptSelInline branch September 14, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
LArSoft pull requests
Included in release
Development

Successfully merging this pull request may close these issues.

None yet

5 participants