New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultipleChoiceSelection.h: added missing inline directives #42
MultipleChoiceSelection.h: added missing inline directives #42
Conversation
A new Pull Request was created by @PetrilloAtWork (Gianluca Petrillo) for develop. It involves the following packages: lardataalg @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The code-checks are being triggered in jenkins. |
-code-checks
Then commit the changes and push them to your PR branch. |
Pull request #42 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again. |
The code-checks are being triggered in jenkins. |
+code-checks |
trigger build |
The tests are being triggered in jenkins. |
+LArSoft tests OK on slf7 for c7:prof |
+LArSoft tests OK on slf7 for e20:prof |
-argoneut tests failed on slf7 for e20:prof |
-icarus tests warning, with build warning,, with ignored warning for build, on slf7 for e20:prof |
-sbnd tests warning, with build warning,, with ignored warning for build, on slf7 for e20:prof |
-dune tests tests warning, with build warning,, with ignored warning for build, on slf7 for e20:prof |
-uboone tests warning on slf7 for e20:prof |
Approved |
This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged.) |
approve |
In the sea of templates, I had missed the few functions which were not templated and need to be declared
inline
.It should fix linking problems in
icaruscode
.