Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultipleChoiceSelection.h: added missing header #48

Merged
merged 1 commit into from Jan 22, 2024

Conversation

PetrilloAtWork
Copy link
Contributor

GitHub commit.

A header inclusion was missing.

@FNALbuild
Copy link
Contributor

A new Pull Request was created by @PetrilloAtWork (Gianluca Petrillo) for develop.

It involves the following packages:

lardataalg

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

@FNALbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@FNALbuild
Copy link
Contributor

+code-checks

PetrilloAtWork added a commit to PetrilloAtWork/icarusalg that referenced this pull request Jan 11, 2024
@lgarren lgarren added this to Approval in progress in LArSoft pull requests Jan 11, 2024
@lgarren
Copy link
Member

lgarren commented Jan 11, 2024

trigger build

@FNALbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@FNALbuild
Copy link
Contributor

+LArSoft tests OK on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/21416&builds=
+build

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

-icarus tests warning, with build warning,, with ignored failure for unit_test,, with ignored warning for build, on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:icarus/view_builds/index?offset=0&builds=icarus_ci/8876&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/21417&builds=

@FNALbuild
Copy link
Contributor

-sbnd tests warning, with build warning,, with ignored warning for build, on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:sbnd/view_builds/index?offset=0&builds=sbnd_ci/13311&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/21417&builds=

@FNALbuild
Copy link
Contributor

-dune tests tests warning, with build warning,, with ignored warning for build, on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:dune/view_builds/index?offset=0&builds=dune_ci/16625&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/21417&builds=

@knoepfel
Copy link
Member

approve

@FNALbuild
Copy link
Contributor

This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests.

@lgarren lgarren merged commit 6e6f05b into LArSoft:develop Jan 22, 2024
1 check passed
LArSoft pull requests automation moved this from Approval in progress to Merged into develop Jan 22, 2024
@lgarren lgarren moved this from Merged into develop to Included in release in LArSoft pull requests Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
LArSoft pull requests
Included in release
Development

Successfully merging this pull request may close these issues.

None yet

4 participants