New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Particle Ancestry Map Fix #38
Particle Ancestry Map Fix #38
Conversation
A new Pull Request was created by @henrylay97 (Henry Lay) for develop. It involves the following packages: lardataobj @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The code-checks are being triggered in jenkins. |
+code-checks |
trigger build |
The tests are being triggered in jenkins. |
+LArSoft tests OK on slf7 for c7:prof |
+LArSoft tests OK on slf7 for e20:prof |
-argoneut tests failed on slf7 for e20:prof |
-icarus tests failed on slf7 for e20:prof |
trigger build |
The tests are being triggered in jenkins. |
-sbnd tests warning on slf7 for e20:prof |
-uboone tests warning on slf7 for e20:prof |
-dune tests tests failed on slf7 for e20:prof |
+LArSoft tests OK on slf7 for c7:prof |
+LArSoft tests OK on slf7 for e20:prof |
-argoneut tests failed on slf7 for e20:prof |
-icarus tests failed on slf7 for e20:prof |
-uboone tests warning on slf7 for e20:prof |
-sbnd tests warning on slf7 for e20:prof |
-dune tests tests failed on slf7 for e20:prof |
approve |
This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests. |
When this object was created in #34 I mistakenly did not declare the member functions to be const. This causes problems for obvious reasons when this object is used after being written to the artroot file. This PR should address that.