Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particle Ancestry Map Fix #38

Merged

Conversation

henrylay97
Copy link
Contributor

When this object was created in #34 I mistakenly did not declare the member functions to be const. This causes problems for obvious reasons when this object is used after being written to the artroot file. This PR should address that.

@FNALbuild
Copy link
Contributor

A new Pull Request was created by @henrylay97 (Henry Lay) for develop.

It involves the following packages:

lardataobj

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

@FNALbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@FNALbuild
Copy link
Contributor

+code-checks

@knoepfel
Copy link
Member

knoepfel commented Jun 1, 2023

trigger build

@FNALbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@FNALbuild
Copy link
Contributor

+LArSoft tests OK on slf7 for c7:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/19546&builds=
+build

@FNALbuild
Copy link
Contributor

+LArSoft tests OK on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/19547&builds=
+build

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

@lgarren lgarren moved this from Awaiting triage to Approval in progress in LArSoft pull requests Jun 1, 2023
@lgarren
Copy link
Member

lgarren commented Jun 1, 2023

trigger build

@FNALbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

+LArSoft tests OK on slf7 for c7:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/19550&builds=
+build

@FNALbuild
Copy link
Contributor

+LArSoft tests OK on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/19551&builds=
+build

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

@lgarren
Copy link
Member

lgarren commented Jun 1, 2023

approve

@FNALbuild
Copy link
Contributor

This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests.

@lgarren lgarren merged commit b1e837e into LArSoft:develop Jun 1, 2023
1 check passed
LArSoft pull requests automation moved this from Approval in progress to Merged into develop Jun 1, 2023
@lgarren lgarren moved this from Merged into develop to Included in release in LArSoft pull requests Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
LArSoft pull requests
Included in release
Development

Successfully merging this pull request may close these issues.

None yet

4 participants