Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particle Ancestry Map #45

Merged

Conversation

henrylay97
Copy link
Contributor

Linked to LArSoft/lardataobj#34

Produce the new sim::ParticleAncestryMap rather than a raw std::map<int, std::set<int>>

@FNALbuild
Copy link
Contributor

A new Pull Request was created by @henrylay97 (Henry Lay) for develop.

It involves the following packages:

larg4

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

@FNALbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@FNALbuild
Copy link
Contributor

-code-checks
Pull request failed code-formatting checks. Please ensure that cetmodules has been setup and execute the following command from the top-level directory of your repository:

format-code \
  larg4/Analysis/CheckMCParticle_module.cc \ 
  larg4/Core/larg4Main_module.cc \ 
  larg4/pluginActions/ParticleListAction.cc

Then commit the changes and push them to your PR branch.

@FNALbuild
Copy link
Contributor

Pull request #45 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.

@FNALbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@FNALbuild
Copy link
Contributor

+code-checks

@lgarren lgarren added this to Awaiting triage in LArSoft pull requests Feb 15, 2023
@knoepfel knoepfel moved this from Awaiting triage to Under discussion in LArSoft pull requests Feb 20, 2023
@knoepfel knoepfel moved this from Under discussion to Approval in progress in LArSoft pull requests Mar 6, 2023
@FNALbuild
Copy link
Contributor

The tests are being triggered in jenkins.
Tested with other pull request(s) LArSoft/lardataobj#34,LArSoft/larsim#110

@FNALbuild
Copy link
Contributor

+LArSoft tests OK on slf7 for c7:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/18775&builds=
+build

@FNALbuild
Copy link
Contributor

+LArSoft tests OK on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/18776&builds=
+build

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

@miquelnebot
Copy link

approve

@FNALbuild
Copy link
Contributor

This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged.)

@lgarren
Copy link
Member

lgarren commented Mar 22, 2023

approve

@lgarren lgarren moved this from Approval in progress to Approved and pending inclusion in release in LArSoft pull requests Mar 22, 2023
@lgarren lgarren merged commit b3d75b5 into LArSoft:develop Mar 24, 2023
LArSoft pull requests automation moved this from Approved and pending inclusion in release to Merged into develop Mar 24, 2023
@lgarren lgarren moved this from Merged into develop to Included in release in LArSoft pull requests Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
LArSoft pull requests
Included in release
Development

Successfully merging this pull request may close these issues.

None yet

4 participants