Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accommodate breaking changes in geometry #36

Merged
merged 1 commit into from Dec 16, 2022
Merged

Accommodate breaking changes in geometry #36

merged 1 commit into from Dec 16, 2022

Conversation

knoepfel
Copy link
Member

@knoepfel knoepfel commented Dec 6, 2022

Pursuant to LArSoft/larcorealg#34.

@FNALbuild
Copy link
Contributor

A new Pull Request was created by @knoepfel (Kyle Knoepfel) for develop.

It involves the following packages:

larrecodnn

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

@FNALbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@FNALbuild
Copy link
Contributor

+code-checks

@knoepfel knoepfel added this to Awaiting triage in LArSoft pull requests Dec 6, 2022
@knoepfel knoepfel mentioned this pull request Dec 6, 2022
Merged
@knoepfel knoepfel moved this from Awaiting triage to Approval in progress in LArSoft pull requests Dec 12, 2022
This was referenced Dec 13, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@FNALbuild
Copy link
Contributor

The tests are being triggered in jenkins.
Tested with other pull request(s) LArSoft/larcorealg#34,LArSoft/larwirecell#27,LArSoft/larana#23,LArSoft/lareventdisplay#18,LArSoft/larevt#20,LArSoft/lardata#30,LArSoft/larpandora#29,LArSoft/larsimdnn#9,LArSoft/larsim#106,LArSoft/larreco#48,LArSoft/larexamples#11,LArSoft/lardataalg#38,LArSoft/larcore#14,DUNE/duneopdet#22,DUNE/dunesw#45,DUNE/dunesim#28,DUNE/dunereco#34,DUNE/duneprototypes#19,DUNE/dunedataprep#15,DUNE/dunecore#42,DUNE/duneana#20,SBNSoftware/icaruscode#496,SBNSoftware/icarusalg#63,SBNSoftware/sbndcode#311,SBNSoftware/sbncode#322

This was referenced Dec 13, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Dec 13, 2022
Merged
Merged
@FNALbuild
Copy link
Contributor

-LArSoft tests failed on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/17824&builds=
-build

@FNALbuild
Copy link
Contributor

-LArSoft tests failed on slf7 for c7:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/17823&builds=
-build

@FNALbuild
Copy link
Contributor

The tests are being triggered in jenkins.
Tested with other pull request(s) LArSoft/larcorealg#34,LArSoft/larwirecell#27,LArSoft/larana#23,LArSoft/lareventdisplay#18,LArSoft/larevt#20,LArSoft/lardata#30,LArSoft/larpandora#29,LArSoft/larsimdnn#9,LArSoft/larsim#106,LArSoft/larreco#48,LArSoft/larexamples#11,LArSoft/lardataalg#38,LArSoft/larcore#14,DUNE/duneopdet#22,DUNE/dunesw#45,DUNE/dunesim#28,DUNE/dunereco#34,DUNE/duneprototypes#19,DUNE/dunedataprep#15,DUNE/dunecore#42,DUNE/duneana#20,SBNSoftware/icaruscode#496,SBNSoftware/icarusalg#63,SBNSoftware/sbndcode#311,SBNSoftware/sbncode#322

@FNALbuild
Copy link
Contributor

+LArSoft tests OK on slf7 for c7:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/17826&builds=
+build

@FNALbuild
Copy link
Contributor

+LArSoft tests OK on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/17825&builds=
+build

@FNALbuild
Copy link
Contributor

-lariat failed on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:lariat/view_builds/index?offset=0&builds=lariat_ci/7466&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/17825&builds=

@FNALbuild
Copy link
Contributor

-sbnd tests failed on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:sbnd/view_builds/index?offset=0&builds=sbnd_ci/10835&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/17825&builds=

@FNALbuild
Copy link
Contributor

-icarus tests failed on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:icarus/view_builds/index?offset=0&builds=icarus_ci/5946&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/17825&builds=

@FNALbuild
Copy link
Contributor

-argoneut tests failed on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:argoneut/view_builds/index?offset=0&builds=argoneut_ci/7767&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/17825&builds=

@FNALbuild
Copy link
Contributor

-uboone tests failed on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:uboone/view_builds/index?offset=0&builds=uboone_ci/8304&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/17825&builds=

@FNALbuild
Copy link
Contributor

-dune tests tests failed on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:dune/view_builds/index?offset=0&builds=dune_ci/14551&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/17825&builds=

@FNALbuild
Copy link
Contributor

Pull request #36 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.

@FNALbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@FNALbuild
Copy link
Contributor

+code-checks

@lgarren lgarren merged commit 1d25fc3 into LArSoft:develop Dec 16, 2022
LArSoft pull requests automation moved this from Approval in progress to Merged into develop Dec 16, 2022
@knoepfel knoepfel deleted the geom-iterator-interface branch December 16, 2022 16:28
@lgarren lgarren moved this from Merged into develop to Included in release in LArSoft pull requests Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved L1-pending L2-pending signatures-pending tests-pending
Projects
LArSoft pull requests
Included in release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knoepfel @FNALbuild @lgarren