Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GENIEGen and other ppfx-related updates #120

Merged
merged 41 commits into from Jul 5, 2023

Conversation

hgreenlee
Copy link
Contributor

Refer to this talk in 6/27/2023 larsoft coordination meeting.

This pull request is dependent on an update of the larsoft version of ppfx (refer to redmine issue 28147).

This pull request updates GENIEGen to add data products bsim::Dk2Nu and bsim::NuChoice to the art event. It also adds weight calculators and source module PPFXFluxReader.

@FNALbuild
Copy link
Contributor

Pull request #120 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.

@FNALbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@FNALbuild
Copy link
Contributor

+code-checks

@lgarren
Copy link
Member

lgarren commented Jun 29, 2023

trigger build

@FNALbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@FNALbuild
Copy link
Contributor

+LArSoft tests OK on slf7 for c7:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/19834&builds=
+build

@FNALbuild
Copy link
Contributor

+LArSoft tests OK on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/19835&builds=
+build

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

-sbnd tests warning, with build warning,, with ignored warning for build, on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:sbnd/view_builds/index?offset=0&builds=sbnd_ci/12141&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/19835&builds=

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

-icarus tests failed, with build warning,, with ignored warning for build, on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:icarus/view_builds/index?offset=0&builds=icarus_ci/7580&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/19835&builds=

@lgarren
Copy link
Member

lgarren commented Jul 3, 2023

approve

@FNALbuild
Copy link
Contributor

This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests.

@lgarren lgarren moved this from Approval in progress to Approved and pending inclusion in release in LArSoft pull requests Jul 3, 2023
@lgarren lgarren merged commit f328389 into LArSoft:develop Jul 5, 2023
1 check passed
LArSoft pull requests automation moved this from Approved and pending inclusion in release to Merged into develop Jul 5, 2023
@knoepfel knoepfel moved this from Merged into develop to Included in release in LArSoft pull requests Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
LArSoft pull requests
Included in release
Development

Successfully merging this pull request may close these issues.

None yet

4 participants