Adding An Ellipsoidal Model for Recombination

[jzennamo]

This PR adds a simulation of an ellipsoidal model for recombination which creates an angular dependence for the recombination model. This is based on this paper https://iopscience.iop.org/article/10.1088/1748-0221/12/12/P12002/pdf and developed further by Gray Putnam (UChicago).

[FNALbuild]

A new Pull Request was created by @jzennamo for develop.

It involves the following packages:

larsim

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

[FNALbuild]

The code-checks are being triggered in jenkins.

[FNALbuild]

-code-checks
Pull request failed code-formatting checks. Please ensure that cetmodules has been setup and execute the following command from the top-level directory of your repository:

format-code \
  larsim/IonizationScintillation/ISCalcCorrelated.cxx \ 
  larsim/IonizationScintillation/ISCalcCorrelated.h \ 
  larsim/LegacyLArG4/ISCalculationCorrelated.h \ 
  larsim/Simulation/LArG4Parameters.h

Then commit the changes and push them to your PR branch.

[FNALbuild]

Pull request #125 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.

[FNALbuild]

The code-checks are being triggered in jenkins.

[FNALbuild]

+code-checks

[knoepfel]

@jzennamo, thanks for the PR. In general, the changes look fine. I've suggested some adjustments below for your consideration.

[FNALbuild]

Pull request #125 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.

[FNALbuild]

The code-checks are being triggered in jenkins.

[FNALbuild]

Pull request #125 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.

[FNALbuild]

Pull request #125 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.

[FNALbuild]

The code-checks are being triggered in jenkins.

[FNALbuild]

+code-checks

[jzennamo]

@tomjunk OK! I think I have added a function to measure the angle of the GEANT step relative to the generalized electric field, please take a look at the new AngleToEFieldAtStep function.

[tomjunk]

Approved

Thanks, Joe!

[FNALbuild]

The tests are being triggered in jenkins.

[FNALbuild]

This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged.)

[FNALbuild]

+LArSoft tests OK on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20928&builds=
+build

[FNALbuild]

-sbnd tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:sbnd/view_builds/index?offset=0&builds=sbnd_ci/12936&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20927&builds=

[FNALbuild]

-icarus tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:icarus/view_builds/index?offset=0&builds=icarus_ci/8442&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20927&builds=

[FNALbuild]

-uboone tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:uboone/view_builds/index?offset=0&builds=uboone_ci/9816&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20927&builds=

[FNALbuild]

-dune tests tests warning on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:dune/view_builds/index?offset=0&builds=dune_ci/16352&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20927&builds=

[lgarren]

approve