Bug Fix; Adding a check that the TPCID is valid in ISCalcCorrelated

[jzennamo]

DUNE-VD informed me that they use ISCalcCorrelated to simulate light outside the TPC volume, this was a use case I did not expect. This causes ISCalcCorrelated to crash because there was no check that the TPCID is valid. This PR adds this check and enables the DUNE-VD simulation to work.

[FNALbuild]

A new Pull Request was created by @jzennamo for develop.

It involves the following packages:

larsim

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

[FNALbuild]

The code-checks are being triggered in jenkins.

[FNALbuild]

-code-checks
Pull request failed code-formatting checks. Please ensure that cetmodules has been setup and execute the following command from the top-level directory of your repository:

format-code \
  larsim/IonizationScintillation/ISCalcCorrelated.cxx

Then commit the changes and push them to your PR branch.

[FNALbuild]

Pull request #129 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.

[FNALbuild]

The code-checks are being triggered in jenkins.

[FNALbuild]

+code-checks

[tomjunk]

Approved.

[knoepfel]

trigger build

[FNALbuild]

The tests are being triggered in jenkins.

[FNALbuild]

+LArSoft tests OK on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/21516&builds=
+build

[FNALbuild]

+LArSoft tests OK on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/21517&builds=
+build

[FNALbuild]

-icarus tests warning, with ignored failure for unit_test, on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:icarus/view_builds/index?offset=0&builds=icarus_ci/8946&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/21517&builds=

[FNALbuild]

-sbnd tests warning on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:sbnd/view_builds/index?offset=0&builds=sbnd_ci/13392&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/21517&builds=

[FNALbuild]

-uboone tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:uboone/view_builds/index?offset=0&builds=uboone_ci/10124&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/21517&builds=

[FNALbuild]

-dune tests tests warning on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:dune/view_builds/index?offset=0&builds=dune_ci/16670&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/21517&builds=

[lgarren]

approve

[FNALbuild]

This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests.