Reads from csv file, skips vehicleAdjustment(No-Op), generates beam v… #3603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ehicles from vehicleInfo and binds to household
Able to run with:
gradle :run -PappArgs="['--config', 'test/input/beamville/beam-urbansimv2-static.conf']"
Config difference:
beam.agentsim.agents.vehicles.vehiclesFilePath = ${beam.inputDirectory}"/vehicles-test.csv"
beam.agentsim.agents.vehicles.vehicleAdjustmentMethod = "STATIC_FROM_FILE"
nikolayilyin
requested changes
Aug 29, 2022
src/main/scala/beam/utils/scenario/UrbanSimScenarioLoader.scala
Outdated
Show resolved
Hide resolved
src/main/scala/beam/utils/scenario/UrbanSimScenarioLoader.scala
Outdated
Show resolved
Hide resolved
src/main/scala/beam/utils/scenario/UrbanSimScenarioLoader.scala
Outdated
Show resolved
Hide resolved
Comment on lines
1
to
15
| include "../common/akka.conf" | ||
| include "../common/metrics.conf" | ||
| include "../common/matsim.conf" | ||
|
|
||
| beam.agentsim.simulationName = "beamville-urbansimv2_input" | ||
| beam.agentsim.agentSampleSizeAsFractionOfPopulation = 1.0 | ||
| beam.agentsim.firstIteration = 0 | ||
| beam.agentsim.lastIteration = 0 | ||
|
|
||
| beam.agentsim.thresholdForWalkingInMeters = 100 | ||
| beam.agentsim.thresholdForMakingParkingChoiceInMeters = 100 | ||
| beam.agentsim.schedulerParallelismWindow = 30 | ||
| beam.agentsim.timeBinSize = 3600 | ||
| beam.agentsim.startTime = "00:00:00" | ||
| beam.agentsim.endTime = "30:00:00" |
There was a problem hiding this comment.
In order to create a config file that has only few config values different there is no need to copy all the content, you migh just include the base config file in the beginning and then put into config file only the config keys you want to change.
For example - test/input/beamville/beam-csv.conf
nikolayilyin
requested changes
Aug 30, 2022
Comment on lines
52
to
53
| vehicles = readVechiclesFromFile() | ||
| vehicleTypesMap = beamScenario.vehicleTypes.map(i => i._1 -> i._2).toMap |
There was a problem hiding this comment.
I would put these rows as first rows (14-15) in the class and replace 'var' with 'val' to emphasize these values are not to be replaced.
nikolayilyin
requested changes
Sep 2, 2022
Comment on lines
131
to
138
| ConfigFactory | ||
| .parseString(s""" | ||
| |beam.agentsim.simulationName = "beamville-urbansimv2_static" | ||
| |beam.agentsim.agents.vehicles.vehiclesFilePath = $${beam.inputDirectory}"/vehicles-test.csv" | ||
| |beam.agentsim.agents.vehicles.vehicleAdjustmentMethod = "STATIC_FROM_FILE" | ||
| """.stripMargin) | ||
| .withFallback(testConfig("test/input/beamville/beam-urbansimv2.conf")) | ||
| .resolve() |
There was a problem hiding this comment.
let's put this config initialization inside the test, no need to create external variable for a test
Comment on lines
120
to
122
| vehiclesBelongToSpecificHousehold.count(x => x.beamVehicleType.id.compareTo( | ||
| Id.create("Bicycle", classOf[BeamVehicleType]) | ||
| ) == 0) shouldBe 7 |
There was a problem hiding this comment.
Let's use equal instead of compareTo
|
test! |
1 similar comment
|
test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ehicles from vehicleInfo and binds to household
Able to run with:
gradle :run -PappArgs="['--config', 'test/input/beamville/beam-urbansimv2-static.conf']"
Config difference:
beam.agentsim.agents.vehicles.vehiclesFilePath = ${beam.inputDirectory}"/vehicles-test.csv"
beam.agentsim.agents.vehicles.vehicleAdjustmentMethod = "STATIC_FROM_FILE"
This change is