Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Actions to build and publish Docker images to Github Container Registry #1004

Merged
merged 14 commits into from
Mar 30, 2024

Conversation

toffee-makes-things
Copy link
Contributor

See #1003

@sudokoko
Copy link
Member

I've approved check runs, if these are successful I will review after work.

@toffee-makes-things
Copy link
Contributor Author

toffee-makes-things commented Mar 28, 2024

also on pull requests IIRC before a merge the Docker workflow does not push to the github container registry, just builds to make sure it works, after merge the workflow reruns and pushes to container registry

@toffee-makes-things
Copy link
Contributor Author

if this workflow is merged to main

you should be able to run something like this docker pull ghcr.io/LBPUnion/projectlighthouse:main and get the docker image for the latest commit

Copy link
Member

@sudokoko sudokoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prelim review

.github/workflows/docker-publish.yml Outdated Show resolved Hide resolved
.github/workflows/docker-publish.yml Show resolved Hide resolved
Copy link
Member

@sudokoko sudokoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second wave of nitpicks, otherwise looks mostly good.

.github/workflows/docker-publish.yml Outdated Show resolved Hide resolved
.github/workflows/docker-publish.yml Outdated Show resolved Hide resolved
@sudokoko sudokoko requested review from Slendy and Zaprit March 29, 2024 01:01
toffee-makes-things and others added 2 commits March 28, 2024 18:02
Co-authored-by: sudokoko <koko@sudokoko.xyz>
Co-authored-by: sudokoko <koko@sudokoko.xyz>
@toffee-makes-things
Copy link
Contributor Author

Done @sudokoko, ignore that one commit message being messed up, phone keyboard did a stupid

@toffee-makes-things toffee-makes-things changed the title Use Actions to publish already built Docker images to Github Container Registry Use Actions to build and publish Docker images to Github Container Registry Mar 29, 2024
Copy link
Member

@Zaprit Zaprit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, main thing is building ARM images.

.github/workflows/docker-publish.yml Show resolved Hide resolved
.github/workflows/docker-publish.yml Show resolved Hide resolved
@toffee-makes-things
Copy link
Contributor Author

@Zaprit all done

toffee-makes-things and others added 3 commits March 29, 2024 20:09
Committing these directly as to not bother you with another code review. Adds a nice-name to the job and renames "build" to "build-publish".
@sudokoko sudokoko added this pull request to the merge queue Mar 30, 2024
Merged via the queue into LBPUnion:main with commit e8441c1 Mar 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants