-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Actions to build and publish Docker images to Github Container Registry #1004
Conversation
GitHub's own template is a little out of date, had to accommodate for this actions/starter-workflows#2357
I've approved check runs, if these are successful I will review after work. |
also on pull requests IIRC before a merge the Docker workflow does not push to the github container registry, just builds to make sure it works, after merge the workflow reruns and pushes to container registry |
if this workflow is merged to main you should be able to run something like this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prelim review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second wave of nitpicks, otherwise looks mostly good.
Co-authored-by: sudokoko <koko@sudokoko.xyz>
Done @sudokoko, ignore that one commit message being messed up, phone keyboard did a stupid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the most part, main thing is building ARM images.
@Zaprit all done |
Committing these directly as to not bother you with another code review. Adds a nice-name to the job and renames "build" to "build-publish".
See #1003