Migrate to sklearn #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LBlend
requested changes
Apr 3, 2022
src/scripts/train_bayes.py
Outdated
| tokens: list[str], trigrams: bool = False, use_stopwords: bool = False | ||
| ) -> dict[str, bool | None]: | ||
| normalized = (token.lower() for token in tokens if token not in punctuation) | ||
| def read_file(path): |
src/scripts/train_bayes.py
Outdated
| import nltk | ||
| import pickle | ||
| from string import punctuation | ||
| from numpy import vectorize |
added 4 commits
April 3, 2022 21:53
LBlend
approved these changes
Apr 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace nltk based bayes model with sklearn.
This also changes parameters in the model so we limit its vocabulary by 5000 tokens.
This is most likely the reason why the nltk bayes model blew up
With new model and vectorizer, it's about 25mb. Is that ok?
I also think the scripts should be rewritten for a different pr. I see clearly that I have learned a lot about readable and idiomatic python code
since i wrote this lol
This closes issue #35