Resolve scenario calculation bug

.github/workflows/comment-milestoned-issues.yaml

@@ -0,0 +1,35 @@
+name: comment when milestone is closed
+on:
+  milestone:
+    types: [closed]
+
+jobs:
+  comment:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Comment on issue
+        uses: actions/github-script@v5
+        with:
+          script: |
+            const milestone_number = context.payload.milestone.number;
+            const milestone_title = context.payload.milestone.title;
+
+            // Get all issues associated with the milestone
+            const issues = await github.rest.issues.listForRepo({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              milestone: milestone_number,
+              state: 'all',
+            });
+
+            // Loop through the issues and if the issue was closed, post a comment referring to the new release
+            for (const issue of issues.data) {
+              if (issue.state === 'closed') {
+                await github.rest.issues.createComment({
+                  owner: context.repo.owner,
+                  repo: context.repo.repo,
+                  issue_number: issue.number,
+                  body: `This issue has been implemented in the [new release of Activity Browser 🚀 (version ${milestone_title})](https://github.com/LCA-ActivityBrowser/activity-browser/releases/tag/${milestone_title}), you can get the new version by [updating Activity Browser](https://github.com/LCA-ActivityBrowser/activity-browser#updating-the-ab).\n\n_🤖beep boop! I'm a bot and this message was an automated action. If updating does not make sense for this issue, just ignore this._`,
+                });
+              }
+            }

.github/workflows/request-review-instructions.yaml

@@ -0,0 +1,32 @@
+name: notify reviewer
+on:
+  pull_request:
+    types: [review_requested]
+
+jobs:
+  comment:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Comment on PR
+        uses: actions/github-script@v5
+        with:
+          script: |
+            const pr_number = context.payload.pull_request.number;
+            const reviewer = context.payload.review.user.login;
+
+            const fs = require('fs');
+            const path = require('path');
+
+            // Read CONTRIBUTING.md
+            const markdown = fs.readFileSync(path.join(process.env.GITHUB_WORKSPACE, '../tree/master/CONTRIBUTING.md'), 'utf8');
+
+            // Extract Reviewing guidelines
+            const section = markdown.split('### Reviewing pull-requests')[1].split('###')[0];
+
+            // Post a comment tagging the reviewer asking them to review following the guidelines
+            await github.rest.issues.createComment({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              issue_number: pr_number,
+              body: `> [!NOTE]\n> @${reviewer}, your review was requested for this Pull Request. Please review this PR following these guidelines:\n\n___\n${section}\n\n\n🤖 _beep boop! I'm a bot and this was an automated message._`,
+            });

activity_browser/bwutils/montecarlo.py

@@ -50,26 +50,11 @@ def __init__(self, cs_name):
         self.activity_keys = [list(fu.keys())[0] for fu in self.func_units]
         self.activity_index = {key: index for index, key in enumerate(self.activity_keys)}
         self.rev_activity_index = {index: key for index, key in enumerate(self.activity_keys)}
-        # previously: self.rev_activity_index = {v: k for k, v in self.activity_keys}
-        # self.fu_index = {k: i for i, k in enumerate(self.activity_keys)}
 
         # methods
         self.methods = self.cs['ia']
         self.method_index = {m: i for i, m in enumerate(self.methods)}
         self.rev_method_index = {i: m for i, m in enumerate(self.methods)}
-        # previously: self.rev_method_index = {v: k for k, v in self.method_index.items()}
-        # self.rev_method_index = {v: k for k, v in self.method_index.items()}
-
-        # todo: get rid of the below
-        self.func_unit_translation_dict = {str(bw.get_activity(list(func_unit.keys())[0])): func_unit
-                                           for func_unit in self.func_units}
-        if len(self.func_unit_translation_dict) != len(self.func_units):
-            self.func_unit_translation_dict = {}
-            for fu in self.func_units:
-                act = bw.get_activity(next(iter(fu)))
-                self.func_unit_translation_dict["{} {}".format(act, act[0])] = fu
-        self.func_key_dict = {m: i for i, m in enumerate(self.func_unit_translation_dict.keys())}
-        self.func_key_list = list(self.func_key_dict.keys())
 
         # GSA calculation variables
         self.A_matrices = list()

activity_browser/bwutils/multilca.py

@@ -170,17 +170,17 @@ def __init__(self, cs_name: str):
         self.process_contributions = np.zeros(
             (len(self.func_units), len(self.methods), self.lca.technosphere_matrix.shape[0]))
 
-        # TODO: get rid of the below
-        self.func_unit_translation_dict = {
-            str(bw.get_activity(list(func_unit.keys())[0])): func_unit for func_unit in self.func_units
-        }
-        if len(self.func_unit_translation_dict) != len(self.func_units):
-            self.func_unit_translation_dict = {}
-            for fu in self.func_units:
-                act = bw.get_activity(next(iter(fu)))
-                self.func_unit_translation_dict["{} {}".format(act, act[0])] = fu
+        name = 'name'
+        ref_prod = 'reference product'
+        db = 'database'
+        self.func_unit_translation_dict = {}
+        for fu in self.func_units:
+            key = next(iter(fu))
+            amt = fu[key]
+            act = bw.get_activity(key)
+            self.func_unit_translation_dict[f'{act[name]} | {act[ref_prod]} | {act[db]} | {amt}'] = fu
         self.func_key_dict = {m: i for i, m in enumerate(self.func_unit_translation_dict.keys())}
-        self.func_key_list = list(self.func_key_dict.keys())
+        self.func_key_list = list(self.func_unit_translation_dict.keys())
 
     def _construct_lca(self):
         return bw.LCA(demand=self.func_units_dict, method=self.methods[0])