Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix production flows from parameter scenario's #1235

Conversation

mrvisscher
Copy link
Collaborator

@mrvisscher mrvisscher commented Feb 19, 2024

Parameter scenario's were giving unexpected results because all the flows that were being extracted from them were labeled as 'Technosphere'-types even though they could also be 'Production'-types. This lead to erroneous outcomes whenever the output flow of an activity has a formula.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide.
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Link this PR to related issues by using closing keywords.
  • Add a milestone to the PR for the intended release.
  • Request a review from another developer.

@mrvisscher mrvisscher added the bug Issues/PRs related to bugs label Feb 19, 2024
@mrvisscher mrvisscher added this to the 2.9.7 milestone Feb 19, 2024
@coveralls
Copy link

Coverage Status

coverage: 50.688%. remained the same
when pulling 7f7fcba on mrvisscher:parameter-scenario-flow-type-fix
into 0955df9 on LCA-ActivityBrowser:master.

@marc-vdm marc-vdm merged commit 32d8084 into LCA-ActivityBrowser:master Feb 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scenario LCA with different DB-Parameters gives odd LCIA-Results
3 participants