-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert variable resolver/restore $dll($dll)) functionality #10
Comments
I see the problem. I did that to work around a nested variable shortcoming without causing a stack overflow but I'm sure there's a better way. I only realised after giving the code another read you can actually nest dll's but I do see where I've broken that. Give me a few days and I'll have the original behaviour back |
No worries! Thank you for all the work on this ancient software, you're single-handedly keeping LCDSmartie alive. |
You're welcome. It was a shame to see it not getting the updates it deserves and please, your feedback is most welcome. If something is not right or if I've done something wrong then just let me know. |
Yep, this works perfectly with legacy LCDSmartie config. Great work! |
… LCD size options Also implemented recursive variable resolver for some other variables. Far from complete as some other resolver functions need complete re-write to take advantage. Can now set custom screen sizes up to 8x100. Re-writing has allowed for even larger displays in future. Some plugins while will likely work it has to be remembered that they were written with only four lines in mind
In version 5.5.3.6 the variable resolver was updated. While I understand reasoning behind the change, and the new $Store and $Fetch functions will be handy, the change broke compatibility with vanilla LCD Smartie configs.
Many users switching to this fork (like me) have configs built over years, heavily utilizing the $dll(dll)) functionality. These configs would need to be rewritten from scratch using the $Store/$Fetch method, which can get anywhere from inelegant to unfeasible in cases with many nested $dll()s
As per title, would you consider restoring nested $dll()s or just reverting to the old resolver?
The text was updated successfully, but these errors were encountered: