move plugin loading log statement to onPluginLoading

LCLPYT · Apr 25, 2023 · 50281ec · 50281ec
1 parent 08a9837
commit 50281ec
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/main/java/work/lclpnet/plugin/DistinctPluginContainer.java b/src/main/java/work/lclpnet/plugin/DistinctPluginContainer.java
@@ -68,10 +68,6 @@ public List<LoadedPlugin> getOrderedDependencies(Set<LoadedPlugin> plugins) {
     public Optional<LoadedPlugin> loadPlugin(LoadablePlugin loadable) {
         lock.lock();
 
-        final var id = loadable.getManifest().id();
-
-        logger.info("Loading plugin '{}'", id);
-
         // check if the plugin can be loaded
         try {
             ensurePluginCanBeLoaded(loadable);
@@ -80,6 +76,7 @@ public Optional<LoadedPlugin> loadPlugin(LoadablePlugin loadable) {
             throw t;
         }
 
+        final var id = loadable.getManifest().id();
         final var loaded = loadable.load();
 
         loadedPlugins.put(id, loaded);
@@ -122,7 +119,7 @@ public Optional<LoadedPlugin> loadPlugin(LoadablePlugin loadable) {
      * @param plugin The loaded plugin, which is about to load.
      */
     protected void onPluginLoading(@SuppressWarnings("unused") LoadedPlugin plugin) {
-
+        logger.info("Loading plugin '{}'", plugin.getId());
     }
 
     /**