New functionality #3
Conversation
Pull Request Test Coverage Report for Build 11
💛 - Coveralls |
Pull Request Test Coverage Report for Build 17
💛 - Coveralls |
|
You use AR_CALCULATION_PRECISION to normalize result of division but you don't have tests for that. |
README.md
Outdated
| `areAllGopsIdentical` field. | ||
| For the full GOPs `processFrames` calculates min/max/mean values of bitrates (in kbit/s), framerates and GOP duration | ||
| (in seconds) and returns them in `payload` field. The result of the check for the similarity of GOP structures for | ||
| the collected GOPs is returned in `areAllGopsIdentical` field. Fields `width`, `height` and `aspectRatio` adjust on |
There was a problem hiding this comment.
It's better to write Fields `width`, `height` and `aspectRatio` are taken from".
and
reflects a presence -> reflects presence.
README.md
Outdated
| mean: 2, | ||
| min: 1.9, | ||
| max: 2.1 }, | ||
| aspectRatio: '16:9', |
There was a problem hiding this comment.
It's better to describe how aspectRatio calculates.
src/processFrames.js
Outdated
| function processFrames(frames) { | ||
| if (!Array.isArray(frames)) { | ||
| throw new TypeError('process method is supposed to accept an array of frames.'); | ||
| } | ||
|
|
||
| const audioFrames = processFrames.filterAudioFrames(frames); |
There was a problem hiding this comment.
You don't use audioFrames array, so you may replace filterAudioFrames function with smth like hasAudioFrames and use Array.some method. It's much more efficient.
src/processFrames.js
Outdated
| return WIDESCREEN_AR; | ||
| } | ||
|
|
||
| return `${width}:${height}`; |
There was a problem hiding this comment.
I think that we need to calculate GCD. It's common technique in ffmpeg.
src/processFrames.js
Outdated
| const baseGopSize = gops[0].frames.length; | ||
| const bitrates = []; | ||
| const fpsList = []; | ||
| const gopsDurations = []; |
There was a problem hiding this comment.
Btw, you can't use gopsDurations. Choose one of the following options: gopDurations or gopsDuration.
In my opinion, gopDurations is better.
video-quality-tools v1.1.0
processFrames:
Added new fields
gopDuration,displayAspectRatio,width,height,hasAudioStreamto the result of processFrames execution .Add new methods to processFrames:
calculateGopDuration,calculateDisplayAspectRatio,hasAudioFrames.FramesMonitor
FramesMonitor fetches video and audio frames from the stream now.
Added
widthandheightinfo to video frames.