Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve stream analyze configuration #98

Merged
merged 13 commits into from
Dec 23, 2019
Merged

Improve stream analyze configuration #98

merged 13 commits into from
Dec 23, 2019

Conversation

oleh-poberezhets
Copy link
Member

Closes 97

@oleh-poberezhets
added flag -rw_timeout to ffprobe command
b3bf68c
@oleh-poberezhets
change timeout naming
fa50ea7
@oleh-poberezhets
fix tests
b3bed11
@oleh-poberezhets
update description and examples
066ce3d
@oleh-poberezhets
update description and examples
1003078
@oleh-poberezhets
add "analyzeduration" option
8d58e16
@oleh-poberezhets
add test for StreamsInfo::_runShowStreamsProcess
df51b63
@oleh-poberezhets
fix remarks
a9683d2
@oleh-poberezhets
Merge branch 'use-"rw_timeout"-option-instead-of-url-parameter-"timeo…
31b9a13 
…ut"' into improve-stream-analyze-configuration

Conflicts:
	README.md
	tests/Unit/FramesMonitor/constructor.test.js
	tests/Unit/StreamsInfo/_runShowStreamsProcess.test.js
@oleh-poberezhets
update Readme
fb24145
@oleh-poberezhets
Merge remote-tracking branch 'origin/master' into improve-stream-anal…
d5df5cf 
…yze-configuration

Conflicts:
	src/FramesMonitor.js
	src/StreamsInfo.js
	tests/Unit/FramesMonitor/_runShowFramesProcess.test.js
	tests/Unit/FramesMonitor/constructor.test.js
	tests/Unit/StreamsInfo/_runShowStreamsProcess.test.js
@coveralls
Copy link

coveralls commented Dec 17, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 295

  • 26 of 26 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 99.662%
Totals Coverage Status
Change from base Build 285: 0.02%
Covered Lines: 421
Relevant Lines: 421
💛 - Coveralls

WoZ
WoZ reviewed Dec 17, 2019
View reviewed changes
Copy link
Member

@WoZ WoZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, is it possible to write a functional test to confirm the correctness of its logic? Like the test in listen.test.js

src/FramesMonitor.js Outdated Show resolved Hide resolved
src/StreamsInfo.js Outdated Show resolved Hide resolved
tests/Unit/FramesMonitor/constructor.test.js Outdated Show resolved Hide resolved
@oleh-poberezhets
Copy link
Member Author

Btw, is it possible to write a functional test to confirm the correctness of its logic? Like the test in listen.test.js

It is hard to reproduce with a static file. This option is useful for live streaming.

@WoZ WoZ merged commit 7ff03af into master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoZ WoZ WoZ left review comments

Assignees

@WoZ WoZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Analyze video with GOP > 5 sec
3 participants
@oleh-poberezhets @coveralls @WoZ