Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix samplers and create good tests for them #82

Closed
stelmo opened this issue Apr 12, 2021 · 3 comments
Closed

Fix samplers and create good tests for them #82

stelmo opened this issue Apr 12, 2021 · 3 comments
Assignees
@stelmo
Labels
quality improves maintainability and code clarity
Milestone
Release - v1.2

Comments

@stelmo
Copy link
Collaborator

stelmo commented Apr 12, 2021

Currently the samplers are not super robust and the testing leaves much to be desired.

  1. Fix ACHR
  2. Add better tests
  3. Add projections to ensure robust sampling in case the samplers go out of bounds
@stelmo stelmo mentioned this issue Apr 12, 2021
Merged
@stelmo stelmo self-assigned this Apr 12, 2021
@stelmo
Copy link
Collaborator Author

stelmo commented Apr 12, 2021

Related to #84

@exaexa
Copy link
Collaborator

exaexa commented Apr 18, 2021

btw are the samplers parallel now? (also, does it make sense to parallelize them?)

@exaexa exaexa added the quality improves maintainability and code clarity label Apr 19, 2021
@stelmo
Copy link
Collaborator Author

stelmo commented Apr 21, 2021

Will be fixed in #109

@laurentheirendt laurentheirendt added this to the Release - v1.2 milestone Apr 30, 2021
@stelmo stelmo closed this as completed May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stelmo stelmo

Labels
quality improves maintainability and code clarity
Projects
None yet
Milestone
Release - v1.2
Development

No branches or pull requests
3 participants
@exaexa @stelmo @laurentheirendt