Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaning & recontenting the file structure #78

Merged
merged 27 commits into from
Apr 12, 2021
Merged

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Apr 9, 2021

This shall close #42 .

Although the size of the PR looks super scary, not much has changed; most of the diff is just moving implementation parts around. Notably, some files were split into new parts of file structure:

  • utils/ contains various misc functions that were bundled with model types and in base/utilities.jl
  • mods/ now contains the "modifications" for models in FBA, categorized by the model they work on; I also separated out mods/generic.jl that work on anything
  • io/show/ for prettyprinting implementations

Other than that, there are a few code changes, mainly regarding the construction of Reaction, Metabolite and Gene

  • redundant constructors were removed and unified to work with new
  • for constructors of more than 4 arguments we now enforce named arguments
  • I simplified the model loading from .M and .json files to enjoy the fact that the structure is mutable
  • I converted occurrences of the wildly popular but non-semantic Array{...,1} to Vector. (Type theory addendum: numbers in types should be avoided at all cost 😁)

One fixup that I packed on the way:

  • CobraModel was renamed to StandardModel also in docs (this will collide with Marvin's PR but it should automerge without much trouble)

src/sampling/test.jl Show resolved Hide resolved
src/types/reaction.jl Outdated Show resolved Hide resolved
src/types/reaction.jl Outdated Show resolved Hide resolved
src/utils/linearmodel.jl Outdated Show resolved Hide resolved
src/utils/standardModel.jl Outdated Show resolved Hide resolved
src/utils/standardModel.jl Outdated Show resolved Hide resolved
@exaexa
Copy link
Collaborator Author

exaexa commented Apr 9, 2021

The comments are resolved separately in #79, merge order ideally #79#78 → master.

@exaexa exaexa changed the title WIP: cleaning & recontenting the file structure cleaning & recontenting the file structure Apr 9, 2021
src/types/standard_model.jl Outdated Show resolved Hide resolved
test/runtests.jl Show resolved Hide resolved
test/sampling/hit_and_run.jl Outdated Show resolved Hide resolved
@laurentheirendt laurentheirendt merged commit 544181f into master Apr 12, 2021
@laurentheirendt laurentheirendt deleted the mk-recontent branch April 12, 2021 14:17
@exaexa
Copy link
Collaborator Author

exaexa commented Apr 12, 2021

🎉 🍾

exaexa pushed a commit that referenced this pull request Jul 8, 2021
cleaning & recontenting the file structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reorganize file contents
3 participants