-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleaning & recontenting the file structure #78
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stelmo
approved these changes
Apr 9, 2021
stelmo
approved these changes
Apr 9, 2021
laurentheirendt
suggested changes
Apr 9, 2021
stelmo
approved these changes
Apr 9, 2021
exaexa
changed the title
WIP: cleaning & recontenting the file structure
cleaning & recontenting the file structure
Apr 9, 2021
stelmo
approved these changes
Apr 9, 2021
laurentheirendt
suggested changes
Apr 12, 2021
format check returns the failure properly
laurentheirendt
approved these changes
Apr 12, 2021
🎉 🍾 |
exaexa
pushed a commit
that referenced
this pull request
Jul 8, 2021
cleaning & recontenting the file structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shall close #42 .
Although the size of the PR looks super scary, not much has changed; most of the diff is just moving implementation parts around. Notably, some files were split into new parts of file structure:
utils/
contains various misc functions that were bundled with model types and inbase/utilities.jl
mods/
now contains the "modifications" for models in FBA, categorized by the model they work on; I also separated outmods/generic.jl
that work on anythingio/show/
for prettyprinting implementationsOther than that, there are a few code changes, mainly regarding the construction of
Reaction
,Metabolite
andGene
new
Array{...,1}
toVector
. (Type theory addendum: numbers in types should be avoided at all cost 😁)One fixup that I packed on the way:
CobraModel
was renamed toStandardModel
also in docs (this will collide with Marvin's PR but it should automerge without much trouble)