Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs reorganization #628

Merged
merged 61 commits into from
Aug 1, 2022
Merged

docs reorganization #628

merged 61 commits into from
Aug 1, 2022

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Jun 6, 2022

Description

This should solve some of the documentation issues that got accumulated during the development. Mostly, this focuses on easy availability of code to run that does various things, instead of having super-specific tutorial with long complex analyses.

Organization

cc @stelmo

Examples (presented as notebooks):

  • Loading models
  • Converting and saving models
  • Exploring models
  • Constructing models
  • FBA
  • FVA
  • Gene deletions
  • Single-reaction modifications
  • pFBA
  • loopless FBA
  • Enzyme crowding
  • Growth media (the MILP version is omitted now)
  • MMDF
  • MOMA
  • sMOMENT
  • GECKO
  • Hit&run sampling
  • Production envelopes

Parallel and distributed processing:

  • Parallelizable functions
  • Local parallelism
  • Running in Slurm
  • Efficient data transfers in HPCs (aka Serialized)

Core concepts:

  • Creating and implementing model variants
  • Optimizer modifications
  • Creating custom models (aka MetabolicModel structure)
  • Extending the models (aka ModelWrapper)

Extra things not to forget:

  • grep TODO
  • git rm -fr docs/src/notebook*

@exaexa exaexa marked this pull request as draft June 6, 2022 08:51
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

🟥  Commit 152addf requires formatting!

Required formatting changes summary:

 docs/make.jl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #628 (bc3027c) into develop (4356673) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #628   +/-   ##
========================================
  Coverage    90.69%   90.69%           
========================================
  Files           79       79           
  Lines         1935     1935           
========================================
  Hits          1755     1755           
  Misses         180      180           
Impacted Files Coverage Δ
src/analysis/sampling/affine_hit_and_run.jl 93.47% <ø> (ø)
src/analysis/envelopes.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07d0262...bc3027c. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

🟥  Commit 85fc1b5 requires formatting!

Required formatting changes summary:

 docs/make.jl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

🟢  Commit 69e6f48 is formatted properly.

@stelmo
Copy link
Collaborator

stelmo commented Jun 6, 2022

Don't forget about the nonfunctional quickstart example with the missing "R_" in the readme

@stelmo
Copy link
Collaborator

stelmo commented Jun 6, 2022

also, Types and Functions => is there a way to only display the most generic function, and not each type dispatched variant?

@exaexa
Copy link
Collaborator Author

exaexa commented Jun 6, 2022

Don't forget about the nonfunctional quickstart example with the missing "R_" in the readme

well check the commits

also, Types and Functions => is there a way to only display the most generic function, and not each type dispatched variant?

probably not in general (also, Julia likely doesn't have the concept of "most generic"). Any specific place where this would help? (I guess the modification overloads?)

@stelmo
Copy link
Collaborator

stelmo commented Jun 6, 2022

probably not in general (also, Julia likely doesn't have the concept of "most generic"). Any specific place where this would help? (I guess the modification overloads?)

Hmm actually, if the examples are done well I don't think this is super necessary (except maybe to group them to make finding the method signatures easier)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

🟥  Commit f8cc414 requires formatting!

Required formatting changes summary:

 docs/make.jl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

🟢  Commit 3e16102 is formatted properly.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

🟢  Commit c0e20d3 is formatted properly.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

🟥  Commit 0343e2e requires formatting!

Required formatting changes summary:

 docs/src/examples/10_crowding.md | 1 -
 1 file changed, 1 deletion(-)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

🟥  Commit c5421e4 requires formatting!

Required formatting changes summary:

 docs/make.jl                     | 9 +++------
 docs/src/examples/10_crowding.md | 1 -
 2 files changed, 3 insertions(+), 7 deletions(-)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

🟥  Commit 841ca39 requires formatting!

Required formatting changes summary:

 docs/make.jl                     | 2 +-
 docs/src/examples/10_crowding.md | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

@exaexa
Copy link
Collaborator Author

exaexa commented Jun 6, 2022

/format

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

✔️ auto-formatting triggered by this comment succeeded, commited as c9a8f46

github-actions bot pushed a commit that referenced this pull request Jun 6, 2022
triggered by @exaexa on PR #628
exaexa added a commit that referenced this pull request Jun 22, 2022
triggered by @exaexa on PR #628
@exaexa exaexa force-pushed the mk-doc-reorg branch 3 times, most recently from 166c75c to 0cf83c2 Compare June 29, 2022 12:38
@LCSB-BioCore LCSB-BioCore deleted a comment from github-actions bot Jun 29, 2022
@LCSB-BioCore LCSB-BioCore deleted a comment from github-actions bot Jun 29, 2022
@LCSB-BioCore LCSB-BioCore deleted a comment from github-actions bot Jun 29, 2022
@LCSB-BioCore LCSB-BioCore deleted a comment from github-actions bot Jun 29, 2022
(Thanks Mo!)
@exaexa exaexa added the documentation Improvements or additions to documentation label Jul 29, 2022
@exaexa exaexa requested a review from stelmo August 1, 2022 10:04
Copy link
Collaborator

@stelmo stelmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rock and roll!

@exaexa exaexa merged commit de1d395 into develop Aug 1, 2022
@exaexa exaexa deleted the mk-doc-reorg branch August 1, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants